----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review96932 -----------------------------------------------------------
src/slave/containerizer/provisioners/docker/registry_client.cpp (line 409) <https://reviews.apache.org/r/37773/#comment152627> I think path may be misleading, can we name this repo? src/slave/containerizer/provisioners/docker/registry_client.cpp (line 415) <https://reviews.apache.org/r/37773/#comment152624> can we do a path::join here? It would be hard to get the "/"s correct just passing path through src/slave/containerizer/provisioners/docker/registry_client.cpp (line 465) <https://reviews.apache.org/r/37773/#comment152628> Same issue with path naming as with getManifest src/slave/containerizer/provisioners/docker/registry_client.cpp (lines 468 - 469) <https://reviews.apache.org/r/37773/#comment152632> Add defaults here as with as with image manifest. - Lily Chen On Aug. 28, 2015, 6:38 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37773/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 6:38 p.m.) > > > Review request for mesos, Lily Chen and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Added implementation for docker registry's Get Manifest and Get Blob APIs. > > > Diffs > ----- > > src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 > src/slave/containerizer/provisioners/docker/registry_client.hpp > PRE-CREATION > src/slave/containerizer/provisioners/docker/registry_client.cpp > PRE-CREATION > src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37773/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jojy Varghese > >
