> On Aug. 28, 2015, 6:46 p.m., Timothy Chen wrote:
> > src/slave/containerizer/provisioners/docker/registry_client.hpp, line 150
> > <https://reviews.apache.org/r/37773/diff/6/?file=1058282#file1058282line150>
> >
> >     Do we need to define static here if it's not being used anywhere else 
> > but the cpp files?

Its a class constant and hence declared here.


> On Aug. 28, 2015, 6:46 p.m., Timothy Chen wrote:
> > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 87
> > <https://reviews.apache.org/r/37773/diff/6/?file=1058283#file1058283line87>
> >
> >     What's the reasoning behind prefixing underscores for these? You've 
> > already added trailing underscores for your class variables right?

The function body uses similar variables. Hence to disambiguate.


> On Aug. 28, 2015, 6:46 p.m., Timothy Chen wrote:
> > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 153
> > <https://reviews.apache.org/r/37773/diff/6/?file=1058283#file1058283line153>
> >
> >     What residue?

The new directory created.


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37773/#review96905
-----------------------------------------------------------


On Aug. 28, 2015, 6:38 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37773/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 6:38 p.m.)
> 
> 
> Review request for mesos, Lily Chen and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added implementation for docker registry's Get Manifest and Get Blob APIs.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/slave/containerizer/provisioners/docker/registry_client.hpp 
> PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/registry_client.cpp 
> PRE-CREATION 
>   src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37773/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to