-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/#review97133
-----------------------------------------------------------



include/mesos/mesos.proto (lines 140 - 154)
<https://reviews.apache.org/r/36321/#comment152897>

    Should this have been:
    
    ```
    message Interval {
      required TimeInfo start;
      optional DurationInfo duration;
    }
    
    message Unavailability {
      required Interval interval;
      
      // Add additional fields related to unavailability.
    }
    ```
    
    Curious if we're going to have to duplicate Interval elsewhere.



include/mesos/mesos.proto (lines 949 - 963)
<https://reviews.apache.org/r/36321/#comment152896>

    Does this need to be required? For example, if we'd like to do ASAP 
de-allocation in the future, what would that look like?
    
    Would we be omitting an unavailability? Or would we be setting the start 
time to 'now'? Also, would we need additional information in the inverse offer 
(e.g. hard vs soft?). Food for thought.


- Ben Mahler


On Aug. 28, 2015, 5:11 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36321/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 5:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2061 and MESOS-2066
>     https://issues.apache.org/jira/browse/MESOS-2061
>     https://issues.apache.org/jira/browse/MESOS-2066
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-2061: Add Unavailability and InverseOffer protobufs declarations.
> MESOS-2066: Add the Unavailability field to Offers.
> 
> Also copied to v1 API.
> 
> No integration with other components (that part is tracked in separate JIRAs, 
> see MESOS-1474).
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto c40a09b2bb2b9444e9b90e86eefe6fc8f98b613d 
>   include/mesos/v1/mesos.proto ee15b9ae70aeb8cf803ea7e4b06f4443bd7bc9e2 
> 
> Diff: https://reviews.apache.org/r/36321/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to