----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96527 -----------------------------------------------------------
Ship it! include/mesos/mesos.proto (line 141) <https://reviews.apache.org/r/36321/#comment151961> Please use a backtick (`) instead. It is rather inconsistent in this file, but we are trying to converge on backticks. include/mesos/mesos.proto (line 935) <https://reviews.apache.org/r/36321/#comment151964> `All the framework's resources on this slave are requested back unless further qualified by the `resources` field.` include/mesos/mesos.proto (line 940) <https://reviews.apache.org/r/36321/#comment151966> I think this is a great comment that users will refer to when discussing Inverse offers. Can we augment it with something similar to: `Any tasks running on the given framework or slave may be killed when the window arrives. Therefore, frameworks should aim to gracefully terminate tasks prior to the arrival of the window.` include/mesos/mesos.proto (line 953) <https://reviews.apache.org/r/36321/#comment151968> `A list of resources being requested back from the framework on the specified `slave_id`.` include/mesos/v1/mesos.proto (line 141) <https://reviews.apache.org/r/36321/#comment151970> same as above w.r.t. backtick. include/mesos/v1/mesos.proto (lines 912 - 957) <https://reviews.apache.org/r/36321/#comment151971> Please adjust as necessary w.r.t. above changes (as you have been doing :-)) - Joris Van Remoortere On Aug. 25, 2015, 10:53 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36321/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 10:53 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, > Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-2061 and MESOS-2066 > https://issues.apache.org/jira/browse/MESOS-2061 > https://issues.apache.org/jira/browse/MESOS-2066 > > > Repository: mesos > > > Description > ------- > > MESOS-2061: Add Unavailability and InverseOffer protobufs declarations. > MESOS-2066: Add the Unavailability field to Offers. > > Also copied to v1 API. > > No integration with other components (that part is tracked in separate JIRAs, > see MESOS-1474). > > > Diffs > ----- > > include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 > include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 > > Diff: https://reviews.apache.org/r/36321/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Joseph Wu > >
