> On Sept. 1, 2015, 7:09 p.m., Ben Mahler wrote: > > src/linux/perf.cpp, line 490 > > <https://reviews.apache.org/r/37442/diff/3/?file=1060677#file1060677line490> > > > > Why not make this an Option<uint64_t> and when it's <not counted> this > > the value is None?
Possible values are uint64_t, double, "<not counted>" and "<not supported>". I'm not sure how useful it is to distingish between the last two but choosing between uint64_t and double cannot be done until we lookup the event. - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/#review97320 ----------------------------------------------------------- On Sept. 1, 2015, 7:49 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37442/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2015, 7:49 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > Factor out the token extraction rules in prepartion for extending them to > cope with multiple versions. > > > Diffs > ----- > > src/linux/perf.cpp dac7061471a0fa05de12cb530bcd5c63a6a71eee > > Diff: https://reviews.apache.org/r/37442/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Paul Brett > >
