----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/#review97426 -----------------------------------------------------------
Patch looks great! Reviews applied: [38046] All tests passed. - Mesos ReviewBot On Sept. 2, 2015, 8:16 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38046/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 8:16 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1935 > https://issues.apache.org/jira/browse/MESOS-1935 > > > Repository: mesos > > > Description > ------- > > Replace hard-coded reap interval with a constant > > > Diffs > ----- > > src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e > src/examples/balloon_executor.cpp 6166f511b8977bc3b6f876de19f1cd91a4a8f03d > src/examples/event_call_framework.cpp > f0058fe0e748e5d91c4b7f0c7569108b00e3eab0 > src/examples/load_generator_framework.cpp > 725478f7162858e9e3136b30476ed1bfbe417681 > src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 > src/master/flags.cpp 230c1dcedfbbb410b89defd90159d964c001a615 > src/slave/constants.cpp cf3ee7bbc252364a1b73731feab6a9da68ee1f55 > src/slave/monitor.cpp 82aa659b02f98ad8dc4c4f556be7a332dfba6816 > src/tests/containerizer/cgroups_tests.cpp > 75a3bc0009c037dc18ce319db2eb44630f083e8c > src/tests/containerizer/docker_tests.cpp > cfad36850b40ade7a41f5b92255320ca1ed1bf93 > src/tests/containerizer/isolator_tests.cpp > d34c82a7f24da6f60cfb22790f516dc6065b1f6f > src/tests/containerizer/launch_tests.cpp > d211fc0f665988068c67836ef80916828a0df2bd > src/tests/fault_tolerance_tests.cpp > 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 > src/tests/gc_tests.cpp ec27ac7f1fca7f425abcea0eafaac4fae905fb8f > src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea > src/tests/limiter.hpp 1bdf8ae85eb4369846c8b367d2f9c81fdaacdf07 > src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e > src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 > src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 > src/tests/slave_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23 > src/tests/slave_tests.cpp 24119183ef04961fe2fdac73de7672cbe5b2408c > src/zookeeper/zookeeper.cpp e44403ee91904415471382dfa4e0a6e0adfdb74f > > Diff: https://reviews.apache.org/r/38046/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >
