> On Sept. 7, 2015, 4:22 p.m., Alexander Rukletsov wrote: > > I would encourage you to check the reaping concept in > > `libprocess/reap.{hpp|cpp}`. Comments in those files should be sufficient > > to understand what's reaping and how we use it in Mesos. Though some of the > > changes you've made may be related to the reaping interval (I haven't deep > > dived into reviewing yet), some of them are definitely not (see examples > > below). > > > > How did you choose candidates for replacing? I thought you did `grep`, but > > surprisingly there is no `reap_tests.cpp` in your RR. I would love us to > > carefully look at each `Seconds(1)` timeout in tests and either replace it > > by the reap interval or leave a comment about the nature of that "one > > second". What do you think? > > Guangya Liu wrote: > I found that we cannot upload one patch with both mesos core part and > 3rdparty code, I have just uploaded a patch for 3rd party for this: > https://reviews.apache.org/r/38168/ > > it is good to add comments for "Seconds(1)", can we handle this in > another patch? I want to focus on reap part for this patch, hope it is OK. ;-)
Sure, separate patch is even better. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/#review97924 ----------------------------------------------------------- On Sept. 8, 2015, 6:16 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38046/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2015, 6:16 a.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-1935 > https://issues.apache.org/jira/browse/MESOS-1935 > > > Repository: mesos > > > Description > ------- > > Replace hard-coded reap interval with a constant > > > Diffs > ----- > > src/tests/containerizer/launch_tests.cpp > d211fc0f665988068c67836ef80916828a0df2bd > src/tests/gc_tests.cpp ec27ac7f1fca7f425abcea0eafaac4fae905fb8f > src/tests/slave_recovery_tests.cpp 6aae14a3c39b9aee76147b691b0170946e1120b5 > src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 > > Diff: https://reviews.apache.org/r/38046/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >