> On Sept. 1, 2015, 4:46 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 553-555 > > <https://reviews.apache.org/r/37826/diff/3/?file=1061137#file1061137line553> > > > > Can you explain why this is a struct rather than a function? > > Alexander Rukletsov wrote: > It's because we cannot partially specialize function templates and > overload won't work since we take the same argument. Do you think a comment > should be expanded?
http://www.gotw.ca/publications/mill17.htm - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37826/#review97302 ----------------------------------------------------------- On Sept. 1, 2015, 2:20 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37826/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2015, 2:20 p.m.) > > > Review request for mesos, Joseph Wu and Michael Park. > > > Bugs: MESOS-3312 > https://issues.apache.org/jira/browse/MESOS-3312 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 57d5fdf45273c620655b44b5f5572290cffa4bf6 > > Diff: https://reviews.apache.org/r/37826/diff/ > > > Testing > ------- > > make check (Mac OS 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
