> On Sept. 3, 2015, 8:37 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 593 > > <https://reviews.apache.org/r/37826/diff/4/?file=1063276#file1063276line593> > > > > The `Parse<T>` above uses `value`, rather than `json`. Can we > > consolidate to one? I think `value` would be more fitting, since we name > > `JSON::Object` as `object`, `JSON::Array` as `array`, etc.
I have a nested `foreach` loop where I use `value` already. I'll rename that one, if you prefer to keep `value` in the signature. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37826/#review97674 ----------------------------------------------------------- On Sept. 3, 2015, 1:32 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37826/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2015, 1:32 p.m.) > > > Review request for mesos, Joseph Wu and Michael Park. > > > Bugs: MESOS-3312 > https://issues.apache.org/jira/browse/MESOS-3312 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 57d5fdf45273c620655b44b5f5572290cffa4bf6 > > Diff: https://reviews.apache.org/r/37826/diff/ > > > Testing > ------- > > make check (Mac OS 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
