-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review97453
-----------------------------------------------------------



src/docker/docker.cpp (line 199)
<https://reviews.apache.org/r/37669/#comment153330>

    s/strVersion/versionString
    
    (Let's not use arbitrary abbreviations where we can avoid it.)



src/docker/docker.cpp (line 201)
<https://reviews.apache.org/r/37669/#comment153332>

    The "[0]" access looks dicy, but after reading the implementation of 
strings::split(), I am fairly convinced that we will never crash here. Such 
tricky code needs to be commented, though. I'd break out the inner split and 
comment on what we are doing there. This seems to erase trailing version string 
components starting with a "-". But how does this relate to what is written in 
line 195? Do we need to worry about splitting at "-" at all?


- Bernd Mathiske


On Aug. 30, 2015, 1:45 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2015, 1:45 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow docker components in version parsing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to