----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review97643 -----------------------------------------------------------
Ship it! src/tests/containerizer/docker_tests.cpp (line 229) <https://reviews.apache.org/r/37669/#comment153656> This is a test of the special case with a "1.7.1.fc22" version string. How about an additional test of the general case like "1.7.1"? - Jan Schlicht On Sept. 3, 2015, 1:16 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37669/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2015, 1:16 p.m.) > > > Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen. > > > Bugs: MESOS-2986 > https://issues.apache.org/jira/browse/MESOS-2986 > > > Repository: mesos > > > Description > ------- > > Ignore overflow docker components in version parsing. > > > Diffs > ----- > > src/docker/docker.cpp 2e17cedb3e29548bdd2d10bd87bd0f61bf123be8 > src/tests/containerizer/docker_tests.cpp > cfad36850b40ade7a41f5b92255320ca1ed1bf93 > > Diff: https://reviews.apache.org/r/37669/diff/ > > > Testing > ------- > > # Add new test case > sudo ./bin/mesos-tests.sh > --gtest_filter="DockerTest.ROOT_DOCKER_parsing_version" --verbose > > > Thanks, > > haosdent huang > >
