----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review97464 -----------------------------------------------------------
Using a ```RefusedFilter``` for this is not the right solution. The point of the suppress call is to have a cheap way to disable offers at a framework granularity. Adding a ```RefusedFilter``` for the total is not cheap. Filters are not ordered and a framework might have already accumulated a lot of filters by declining offers. All that is needed is a boolean flag on the framework. - James Peach On Aug. 31, 2015, 5:49 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37873/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2015, 5:49 a.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-3037 > https://issues.apache.org/jira/browse/MESOS-3037 > > > Repository: mesos > > > Description > ------- > > Add quiesce logic in allocator > > > Diffs > ----- > > include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a > src/master/allocator/mesos/allocator.hpp > aa55755a9c3250579e9366bdbc17a2449e95d659 > src/master/allocator/mesos/hierarchical.hpp > 38f8fd2c84314bb3731684d0e9795cb4f50a227e > src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf > src/tests/mesos.hpp b2160f50db3e0b0d04b0625e7589004016c0f746 > > Diff: https://reviews.apache.org/r/37873/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >
