> On Aug. 30, 2015, 5:10 p.m., Robert Lacroix wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 153 > > <https://reviews.apache.org/r/37873/diff/3/?file=1059860#file1059860line153> > > > > Are we quiescing resources or rather offers? I think it should be > > called `quiesceOffers` so it's symmetrical to `reviveOffers`.
Technically, allocator does not know anything about offers, only about allocations. This may change soon (we think about pulling offers management into allocator), but until then I find this naming misleading. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review97031 ----------------------------------------------------------- On Aug. 31, 2015, 5:49 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37873/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2015, 5:49 a.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-3037 > https://issues.apache.org/jira/browse/MESOS-3037 > > > Repository: mesos > > > Description > ------- > > Add quiesce logic in allocator > > > Diffs > ----- > > include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a > src/master/allocator/mesos/allocator.hpp > aa55755a9c3250579e9366bdbc17a2449e95d659 > src/master/allocator/mesos/hierarchical.hpp > 38f8fd2c84314bb3731684d0e9795cb4f50a227e > src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf > src/tests/mesos.hpp b2160f50db3e0b0d04b0625e7589004016c0f746 > > Diff: https://reviews.apache.org/r/37873/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >
