----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37921/#review97509 -----------------------------------------------------------
Ship it! src/slave/containerizer/provisioners/backends/copy.hpp (lines 41 - 42) <https://reviews.apache.org/r/37921/#comment153414> This requirement is no longer true. src/slave/containerizer/provisioners/backends/copy.cpp (line 135) <https://reviews.apache.org/r/37921/#comment153419> Are we sure if the layer previous didn't have the trailing slash. AppcProvisioner does make sure but within this file perhaps it won't hurt to check. i.e., trim the tail first and then add a trailing list. src/slave/containerizer/provisioners/backends/copy.cpp (line 139) <https://reviews.apache.org/r/37921/#comment153420> One blank line above. - Jiang Yan Xu On Sept. 2, 2015, 9:54 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37921/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 9:54 a.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-2968 > https://issues.apache.org/jira/browse/MESOS-2968 > > > Repository: mesos > > > Description > ------- > > Add Copy backend for provisioners. > > > Diffs > ----- > > src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5 > src/slave/containerizer/provisioners/backend.cpp > 2f7c335f62fdeb27526ab9a38a07c097422ae92b > src/slave/containerizer/provisioners/backends/copy.hpp PRE-CREATION > src/slave/containerizer/provisioners/backends/copy.cpp PRE-CREATION > src/tests/containerizer/provisioner_backend_tests.cpp > d321850613223a2357ca1646a9d988d05171772c > > Diff: https://reviews.apache.org/r/37921/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
