> On Sept. 1, 2015, 3:34 a.m., Michael Park wrote:
> > Just a bunch of high-level questions here.
> > 
> > It looks like you followed the pattern for 
> > `src/examples/test_framework.cpp`.
> > I think it would be probably better to follow 
> > `src/examples/persistent_volume_framework.cpp` since
> > 
> > 1. It's likely that people will visit dynamic reservation and persistent 
> > volumes together.
> > 2. There are many components (e.g. authorization, implicit status update 
> > acknowledgements, etc) included in the test_framework that are there for 
> > demo purposes. I think it would be better to keep this example's scope to 
> > dynamic reservation, and it should lead us to a simpler example.
> > 
> > Also, do we need the custom executor for some reason? It doesn't seem to be 
> > doing much currently?
> > 
> > Another high-level question is, how would you describe what `State` 
> > represents?
> > It seems like it's associated with every offer, would it makes more sense 
> > to associate it with a task instead?
> 
> Klaus Ma wrote:
>     1. Yes, I followed test_framework.cpp; and I'll polish it by following 
> persistent_volume_framework.cpp.
>     2. Regarding the executor, we can use test_executor.cpp to replase.
>     3. For State, it describe whether a slave has reserved resources; it's an 
> example for the daemon on each slave host, such as NameNode.
>     
>     I'll update the code to address 1 & 2; if any more comments, i'll 
> continue to address them :).

1. Great, thanks!
2. I don't think you even need `test_executor.cpp`, do you? 
`test_framework.cpp` for example doesn't use `text_executor.cpp`, just uses 
command executor I believe.
3. Makes sense to me, thanks for the explanation :)


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review97232
-----------------------------------------------------------


On Aug. 28, 2015, 3:31 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 3:31 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3063
>     https://issues.apache.org/jira/browse/MESOS-3063
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-3063 (Add an example framework using dynamic reservation)
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7b620ff 
>   src/examples/dynamic_reservation_executor.cpp PRE-CREATION 
>   src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
>   src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
>   src/tests/examples_tests.cpp 3f56b30 
>   src/tests/flags.hpp 3644956 
>   src/tests/script.cpp bcc1fab 
> 
> Diff: https://reviews.apache.org/r/37168/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Reply via email to