-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38003/#review97785
-----------------------------------------------------------



src/master/master.cpp (lines 306 - 312)
<https://reviews.apache.org/r/38003/#comment153801>

    Just do this.
    
    ```
    
    // Master ID is generated randomly based on UUID.
    info_.set_id(UUID::random().toString());
    
    ```



src/tests/master_tests.cpp (line 3607)
<https://reviews.apache.org/r/38003/#comment153802>

    All our comments are expected to be proper sentences, i.e., start with a 
capital letter and end with period. Please fix here and everywhere.



src/tests/master_tests.cpp (lines 3638 - 3666)
<https://reviews.apache.org/r/38003/#comment153803>

    Why do you need to launch a scheduler and task for this test?
    
    I think you can simplify this test by not launching them.


- Vinod Kone


On Sept. 1, 2015, 2:44 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38003/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 2:44 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3351
>     https://issues.apache.org/jira/browse/MESOS-3351
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-3351 (duplicated slave id in master after master failover)
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
> 
> Diff: https://reviews.apache.org/r/38003/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Reply via email to