-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38003/
-----------------------------------------------------------
(Updated Sept. 5, 2015, 2:46 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Address Vinod's comments
Summary (updated)
-----------------
MESOS-3351 (duplicated slave id in master after master failover)
Bugs: MESOS-3351
https://issues.apache.org/jira/browse/MESOS-3351
Repository: mesos
Description (updated)
-------
__Phenomenon:__
In some race condition, the slave was shutdown when after master failover.
__Root Cause:__
The slave was shutdown because of duplicated SlavID: in master, the SlaveID is
genereated by masterInfo.id + "-S" + nextSlaveId; when master failover,
nextSlaveId was reset to 0 and masterInfo.id (generated by date + ip + port +
pid) maybe un-changed which lead to duplicated SlaveID.
__Solution/Fix:__
Generate masterInfo.id by UUID instead of "date + ip + port + pid".
Diffs (updated)
-----
src/master/master.cpp 5589eca
src/tests/master_tests.cpp 8a6b98b
Diff: https://reviews.apache.org/r/38003/diff/
Testing
-------
make
make check
Thanks,
Klaus Ma
