This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 5, 2015, 2:46 a.m.)

Review request for mesos and Vinod Kone.


Address Vinod's comments

Summary (updated)

MESOS-3351 (duplicated slave id in master after master failover)

Bugs: MESOS-3351

Repository: mesos

Description (updated)

In some race condition, the slave was shutdown when after master failover.

__Root Cause:__
The slave was shutdown because of duplicated SlavID: in master, the SlaveID is 
genereated by masterInfo.id + "-S" + nextSlaveId; when master failover, 
nextSlaveId was reset to 0 and masterInfo.id (generated by date + ip + port + 
pid) maybe un-changed which lead to duplicated SlaveID. 

Generate masterInfo.id by UUID instead of "date + ip + port + pid".

Diffs (updated)

  src/master/master.cpp 5589eca 
  src/tests/master_tests.cpp 8a6b98b 

Diff: https://reviews.apache.org/r/38003/diff/


make check


Klaus Ma

Reply via email to