----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/#review98026 -----------------------------------------------------------
Ship it! Just a bit more cleanup, and I think this would be good to go. If possible, you should coordinate with Alex Clemmer to make sure this change doesn't conflict/break what he's working on (https://reviews.apache.org/r/37019/). 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat (lines 19 - 21) <https://reviews.apache.org/r/37273/#comment154293> Not sure if these comments are necessary. If anything, just keep one: ``` :: Path to the solution (.sln) file being built. set SOLUTION_FILE=%-1 ``` 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat (lines 23 - 24) <https://reviews.apache.org/r/37273/#comment154294> Put a newline before the comment. Suggestion: ``` :: List of project names delimited by '#'. ``` 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat (line 42) <https://reviews.apache.org/r/37273/#comment154172> I think you don't need this anymore. 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat (line 48) <https://reviews.apache.org/r/37273/#comment154173> Not necessary anymore. 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat (line 52) <https://reviews.apache.org/r/37273/#comment154174> Not used. - Joseph Wu On Sept. 5, 2015, 5:43 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37273/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2015, 5:43 a.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Add CMake macro VsBuildCommand in libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 997cc0d0e316e316136d4746e50e9e292a82b36b > 3rdparty/libprocess/cmake/ProcessConfigure.cmake > 12506a1369de005285268f895f365aba0c560f78 > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake > 9e4dcb83a8cc4e95a2a38573944f6b38e2eac76e > 3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION > 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION > 3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/37273/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
