> On Sept. 11, 2015, 10:41 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 192 > > <https://reviews.apache.org/r/37273/diff/6/?file=1065772#file1065772line192> > > > > Hmm, does protobuf build for you? This command should fail on VS2015 > > because stdex is not included in VS2015 (see[1] and [2]). > > > > Because this issue does not appear to be resolved in the current > > release of protobuf[3], we will probably need to change the projects to > > include `-D _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS`, either through a > > patch file, or by somehow passing the flags into the build system on > > Windows. I'm not sure which is more realistic. > > > > [1] > > http://stackoverflow.com/questions/30430789/c-hash-deprecation-warning > > [2] > > http://blogs.msdn.com/b/vcblog/archive/2014/06/06/c-14-stl-features-fixes-and-breaking-changes-in-visual-studio-14-ctp1.aspx > > [3] https://github.com/google/protobuf/issues/792
Yes, could not compile it. So I have a protobuf-2.5.0.patch before. https://reviews.apache.org/r/37273/diff/1#1 Should we use bundle way to work arround this problem? - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/#review98687 ----------------------------------------------------------- On Sept. 15, 2015, 4:40 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37273/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 4:40 p.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Add CMake macro VsBuildCommand in libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > d13ba666740b4f2e382a0b1852724cfd519f8f64 > 3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION > 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION > 3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/37273/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
