-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37826/#review98370
-----------------------------------------------------------

Ship it!


Looks good!


3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (line 602)
<https://reviews.apache.org/r/37826/#comment154831>

    Would `_value` be better than `v` here? Maybe `elem`...?



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (lines 622 - 623)
<https://reviews.apache.org/r/37826/#comment154828>

    > overload will not work because ...
    
    As I mentioned in my comment in reply to Joseph's question, the overloaded 
functions approach with the use of `enable_if` would work but not as clean.


- Michael Park


On Sept. 9, 2015, 2:46 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37826/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 2:46 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Michael Park.
> 
> 
> Bugs: MESOS-3312
>     https://issues.apache.org/jira/browse/MESOS-3312
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 57d5fdf45273c620655b44b5f5572290cffa4bf6 
> 
> Diff: https://reviews.apache.org/r/37826/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to