> On Sept. 8, 2015, 11:04 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 140-143
> > <https://reviews.apache.org/r/37032/diff/3/?file=1064256#file1064256line140>
> >
> >     I don't think it's obvious from reading this the first time that you're 
> > about to describe an open question / problem. Could you make this more 
> > clear?

I'm not sure what we mean by "open problem", but I think part of the problem 
might be that the "execute permissions" section was misplaced between the two 
parts of the "flag strictness" comments. This is fixed in the upcoming review.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37032/#review98102
-----------------------------------------------------------


On Sept. 10, 2015, 7:36 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37032/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 7:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Extend permissions.hpp to work on both Windows and POSIX.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 8853f92fcfcff81d0a3197bade02110685fa0325 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/permissions.hpp 
> 196c3f5fac7c3526924f2bea03c06d1fbce25c61 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/permissions.hpp 
> 98f0b3c8e55190df87d6a581667e21b31ac044bc 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/permissions.hpp 
> daed4b4e9c76d6e7c043a1fa3a46ab1f3db95f48 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 7ab75ece44ab4b0cc42f992daf1101d0faf80b1f 
> 
> Diff: https://reviews.apache.org/r/37032/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to