> On Sept. 8, 2015, 3:51 p.m., Artem Harutyunyan wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/permissions.hpp, line 57
> > <https://reviews.apache.org/r/37032/diff/3/?file=1064253#file1064253line57>
> >
> >     A comment describing why do we need this function would be great.
> 
> Alex Clemmer wrote:
>     Just to make sure we're on the same page, this function is moving here -- 
> I didn't write it. It looks like it's used only in the fetcher tests and the 
> `credentials.hpp`, so my guess is it's not really _needed_. But either way, 
> I'd like to suggest that I'm not the best person to provide this 
> justification.

OK. Thanks for clarifying.


- Artem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37032/#review98092
-----------------------------------------------------------


On Sept. 10, 2015, 12:36 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37032/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 12:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Extend permissions.hpp to work on both Windows and POSIX.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 8853f92fcfcff81d0a3197bade02110685fa0325 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/permissions.hpp 
> 196c3f5fac7c3526924f2bea03c06d1fbce25c61 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/permissions.hpp 
> 98f0b3c8e55190df87d6a581667e21b31ac044bc 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/permissions.hpp 
> daed4b4e9c76d6e7c043a1fa3a46ab1f3db95f48 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 7ab75ece44ab4b0cc42f992daf1101d0faf80b1f 
> 
> Diff: https://reviews.apache.org/r/37032/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to