> On Sept. 11, 2015, 4:57 a.m., Jojy Varghese wrote:
> > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 386
> > <https://reviews.apache.org/r/38289/diff/1/?file=1067993#file1067993line386>
> >
> > This block should be refactored out so that it can be handled in line
> > 278 also.
Not sure what you mean, this is 278:
if (!resend) {
return Failure("Bad response: " + httpResponse.status);
}
A Bad request shouldn't trigger a resend right?
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38289/#review98553
-----------------------------------------------------------
On Sept. 11, 2015, 3:58 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38289/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 3:58 a.m.)
>
>
> Review request for mesos and Jojy Varghese.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Handle bad request in Docker registry client.
>
>
> Diffs
> -----
>
> src/Makefile.am 8963cea9fd7e3bee450a1059e6383e5ab868a17b
> src/slave/containerizer/provisioners/docker/registry_client.hpp
> PRE-CREATION
> src/slave/containerizer/provisioners/docker/registry_client.cpp
> PRE-CREATION
> src/tests/provisioners/docker_provisioner_tests.cpp
> ff29d562c7f1bd5f0579e97cdbd60c2b2f36329e
>
> Diff: https://reviews.apache.org/r/38289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
