> On Sept. 11, 2015, 3:09 a.m., haosdent huang wrote: > > src/linux/cgroups.cpp, line 2440 > > <https://reviews.apache.org/r/38287/diff/1/?file=1067958#file1067958line2440> > > > > Does this fall into a loop? > > Jian Qiu wrote: > Does not quite catch your point :) if you mean the loop in > internal::Freezer::freeze, I think it does not.
Oh, I mean if future keep failed, does this fall into a infinite loop? - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/#review98540 ----------------------------------------------------------- On Sept. 11, 2015, 3:05 a.m., Jian Qiu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38287/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 3:05 a.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Paul Brett. > > > Bugs: MESOS-3272 > https://issues.apache.org/jira/browse/MESOS-3272 > > > Repository: mesos > > > Description > ------- > > This check in cgroups::freezer::freeze() is necessary > since the freezer process can be terminated in its > initialize method > > > Diffs > ----- > > src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f > > Diff: https://reviews.apache.org/r/38287/diff/ > > > Testing > ------- > > ./mesos-tests.sh > --gtest_filter="CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer" > --verbose > > > Thanks, > > Jian Qiu > >
