----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38305/#review98628 -----------------------------------------------------------
Ship it! LGTM. General question: Does `using namespace` hurt, even in a test? 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp (line 35) <https://reviews.apache.org/r/38305/#comment155147> I might be missing something, but I don't see this class used in this file. - Joseph Wu On Sept. 11, 2015, 10:09 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38305/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 10:09 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joseph Wu, Michael Park, and > Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp > ebf8cd656625b7fd414cacaa87f156c95df29438 > > Diff: https://reviews.apache.org/r/38305/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
