> On Sept. 11, 2015, 5:21 p.m., Joseph Wu wrote:
> > LGTM.
> > 
> > General question: Does `using namespace` hurt, even in a test?

It doesn't exactly "hurt". There have been a few discussions recently around 
not polluting the namespaces (google style guide) and cleaning up the existing 
`using namespace` declarations.
Since people tend to copy code, I think it's a good idea to try and be 
consistent accross the code-base.


> On Sept. 11, 2015, 5:21 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 35
> > <https://reviews.apache.org/r/38305/diff/1/?file=1068669#file1068669line35>
> >
> >     I might be missing something, but I don't see this class used in this 
> > file.

It's used in the for loop inside `TEST(FlagsTest, Stringification)`


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38305/#review98628
-----------------------------------------------------------


On Sept. 11, 2015, 5:09 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38305/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 5:09 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joseph Wu, Michael Park, and 
> Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
> ebf8cd656625b7fd414cacaa87f156c95df29438 
> 
> Diff: https://reviews.apache.org/r/38305/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to