-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 12:59 p.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Rebase
Bugs: MESOS-3136
https://issues.apache.org/jira/browse/MESOS-3136
Repository: mesos
Description
-------
Fix broken health check in docker executor.
Diffs (updated)
-----
src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403
src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9
src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e
src/slave/containerizer/docker.cpp 289d4ec0fba9071dfe0cbf5391b5391d4566dd9c
src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea
Diff: https://reviews.apache.org/r/37505/diff/
Testing
-------
# Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and
HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
# Docker health check command is run through "docker exec"
sudo ./bin/mesos-tests.sh
--gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose
sudo ./bin/mesos-tests.sh
--gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange" --verbose
Thanks,
haosdent huang
