----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/#review97053 -----------------------------------------------------------
src/docker/executor.cpp (line 306) <https://reviews.apache.org/r/37505/#comment152772> End comment with period src/docker/executor.cpp (line 310) <https://reviews.apache.org/r/37505/#comment152771> End comment with period src/docker/executor.cpp (line 315) <https://reviews.apache.org/r/37505/#comment152770> You're still continuning to launch the health check even when the version is not met? src/docker/executor.cpp (line 352) <https://reviews.apache.org/r/37505/#comment152773> Can you log that docker executor doesn't yet support the other health check type with a else block? src/docker/executor.cpp (line 361) <https://reviews.apache.org/r/37505/#comment152774> You should be able to push the arguments with another vector insert? e.g: argv.push_back("--executor"); argv.push_back(stringify(self()); ..... src/tests/health_check_tests.cpp (line 254) <https://reviews.apache.org/r/37505/#comment152775> We shouldn't run this if docker daemon is < 1.3.0 right? You should check and disable the test if you found it. src/tests/health_check_tests.cpp (line 322) <https://reviews.apache.org/r/37505/#comment152776> Why also test reconciliation? - Timothy Chen On Aug. 30, 2015, 10:23 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37505/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2015, 10:23 a.m.) > > > Review request for mesos, Adam B and Timothy Chen. > > > Bugs: MESOS-3136 > https://issues.apache.org/jira/browse/MESOS-3136 > > > Repository: mesos > > > Description > ------- > > Fix broken health check in docker executor. > > > Diffs > ----- > > src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b > src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 > src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 > src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad > src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea > > Diff: https://reviews.apache.org/r/37505/diff/ > > > Testing > ------- > > # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and > HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange > # Docker health check command is run through "docker exec" > sudo ./bin/mesos-tests.sh > --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose > sudo ./bin/mesos-tests.sh > --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange" > --verbose > > > Thanks, > > haosdent huang > >
