----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38370/#review98923 -----------------------------------------------------------
+1 on Tim's comment. I think you can just generalize the text to '3rd party tools' Is there a corresponding test we could change to verify that this works as expected? - Niklas Nielsen On Sept. 14, 2015, 1:55 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38370/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 1:55 p.m.) > > > Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Timothy > Chen. > > > Bugs: MESOS-3013 > https://issues.apache.org/jira/browse/MESOS-3013 > > > Repository: mesos > > > Description > ------- > > Updated docker executor to set container IP in TaskStatus::NetworkInfo. > > > Diffs > ----- > > src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e > > Diff: https://reviews.apache.org/r/38370/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Kapil Arya > >
