> On Sept. 16, 2015, 3:44 p.m., Niklas Nielsen wrote: > > src/docker/executor.cpp, lines 162-164 > > <https://reviews.apache.org/r/38370/diff/2/?file=1074454#file1074454line162> > > > > Was "Docker.NetworkSettings.IPAddress" in 0.24.0? If so, don't we want > > to deprecate this over a release cycle? (Supporting both in the interim)
done! - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38370/#review99284 ----------------------------------------------------------- On Sept. 16, 2015, 3:52 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38370/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2015, 3:52 p.m.) > > > Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Timothy > Chen. > > > Bugs: MESOS-3013 > https://issues.apache.org/jira/browse/MESOS-3013 > > > Repository: mesos > > > Description > ------- > > Updated docker executor to set container IP in TaskStatus::NetworkInfo. > > > Diffs > ----- > > src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e > src/tests/containerizer/docker_containerizer_tests.cpp > a628922cc49b1dc8a37621a6a8b7ef6842cfb051 > > Diff: https://reviews.apache.org/r/38370/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Kapil Arya > >
