-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38364/#review98938
-----------------------------------------------------------

Ship it!



src/slave/containerizer/mesos/containerizer.cpp (lines 830 - 833)
<https://reviews.apache.org/r/38364/#comment155700>

    How about moving this up as well?


- Niklas Nielsen


On Sept. 14, 2015, 2:54 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38364/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 2:54 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3387
>     https://issues.apache.org/jira/browse/MESOS-3387
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change moves two different pieces of code, that each iterate over list 
> of ContainerPrepareInfos, close together for readability. It becomes even 
> more relevant when looking at https://reviews.apache.org/r/38365/ that 
> iterates over yet another member from ContainerPrepareInfo.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 1b83a8725b35435531038e37188b4c97189cef03 
> 
> Diff: https://reviews.apache.org/r/38364/diff/
> 
> 
> Testing
> -------
> 
> make  check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Reply via email to