> On Sept. 14, 2015, 6:55 p.m., Niklas Nielsen wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 832-843 > > <https://reviews.apache.org/r/38364/diff/1/?file=1072929#file1072929line832> > > > > How about moving this up as well?
Fixed. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38364/#review98938 ----------------------------------------------------------- On Sept. 15, 2015, 5:02 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38364/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 5:02 p.m.) > > > Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen. > > > Bugs: MESOS-3387 > https://issues.apache.org/jira/browse/MESOS-3387 > > > Repository: mesos > > > Description > ------- > > This change moves two different pieces of code, that each iterate over list > of ContainerPrepareInfos, close together for readability. It becomes even > more relevant when looking at https://reviews.apache.org/r/38365/ that > iterates over yet another member from ContainerPrepareInfo. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 1b83a8725b35435531038e37188b4c97189cef03 > > Diff: https://reviews.apache.org/r/38364/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
