> On Sept. 15, 2015, 11:23 a.m., haosdent huang wrote: > > src/master/http.cpp, line 670 > > <https://reviews.apache.org/r/38347/diff/1/?file=1072271#file1072271line670> > > > > Could you also document the parameters about the reserve/unreserve > > endpoints? For example: /logging endpoint document his parameters in > > [description](https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/logging.cpp#L84-L96). > > Another question is assume I am a newbie developer, I want to call > > reserve/unserve, should I concern some exception return codes here?
Our help descriptions in mesos use markdown to render. After you finish the patch and build it local, you could use `mesos-local` and open `http://localhost:5050/help/logging/toggle`, `http://localhost:5050/help/master/reserve` to compare their format. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38347/#review99010 ----------------------------------------------------------- On Sept. 14, 2015, 8:47 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38347/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 8:47 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3419 > https://issues.apache.org/jira/browse/MESOS-3419 > > > Repository: mesos > > > Description > ------- > > Add HELP Message for Reserve/Unreserve endpoint > > > Diffs > ----- > > src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80 > src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24 > src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 > > Diff: https://reviews.apache.org/r/38347/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >
