> On Sept. 15, 2015, 11:23 a.m., haosdent huang wrote:
> > src/master/http.cpp, line 670
> > <https://reviews.apache.org/r/38347/diff/1/?file=1072271#file1072271line670>
> >
> >     Could you also document the parameters about the reserve/unreserve 
> > endpoints? For example: /logging endpoint document his parameters in 
> > [description](https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/logging.cpp#L84-L96).
> >  Another question is assume I am a newbie developer, I want to call 
> > reserve/unserve, should I concern some exception return codes here?
> 
> haosdent huang wrote:
>     Our help descriptions in mesos use markdown to render. After you finish 
> the patch and build it local, you could use `mesos-local` and open 
> `http://localhost:5050/help/logging/toggle`, 
> `http://localhost:5050/help/master/reserve` to compare their format.

Thanks Haosdent! Here I was updatin the HELP message by adding two important 
parameters and also test via http://localhost:5050/help/master/reserve 
http://localhost:5050/help/master/unreserve


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38347/#review99010
-----------------------------------------------------------


On Sept. 14, 2015, 8:47 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38347/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 8:47 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3419
>     https://issues.apache.org/jira/browse/MESOS-3419
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add HELP Message for Reserve/Unreserve endpoint
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 
> 91991f509e480a94de00c6bf20ff0abf083dda8a 
>   CHANGELOG cd71399ccace5b9f7c03cb5fcf65f55256b63e4a 
>   docs/getting-started.md 35c8c566fff83abfcfcce177bfb9a35454f26494 
>   docs/persistent-volume.md ae5b0e53997c9cb2a8bab22e0109e6768124f82b 
>   docs/release-guide.md 980055e2e937653f0b687ba1395c5b6c59b7838d 
>   include/mesos/maintenance/maintenance.hpp 
> f676d01c2c81250b6e4740ab0934f966b50ed76d 
>   include/mesos/master/allocator.hpp fb09e2a6502bc8c78ddcc8a595bcd9320da136ea 
>   include/mesos/master/allocator.proto 
> b42f19def20ac3144e07144aece0da6873888b02 
>   include/mesos/scheduler/scheduler.proto 
> 19f548dba4b5d72fca8e692c5f15796feca17106 
>   include/mesos/type_utils.hpp 6cedf079c710c7d6ab8f95c47c133e6a1efe9a82 
>   include/mesos/v1/mesos.hpp 260e1125dea792ebcece404f94363e8c4bc36f28 
>   include/mesos/v1/scheduler/scheduler.proto 
> 0118b46afca8a5adecb0e65981dd44bb98333bab 
>   src/Makefile.am 509256f40ecc1ff5b3a5ce2b380facd153137a18 
>   src/authentication/cram_md5/authenticator.cpp 
> f238872476d422856db48bd845d5941911fdf2b0 
>   src/internal/devolve.hpp f03cac5ce93fead70122ae76d537867f958317fe 
>   src/internal/devolve.cpp 6cace660ef81a82ffab8b86d70c364a0718cffda 
>   src/internal/evolve.hpp 9babac3ccbfb2bf9a3989a3ae20cf96e5f3a2903 
>   src/internal/evolve.cpp 625706e089984b32d8298a2eacf2f8af2bca931e 
>   src/master/allocator/mesos/allocator.hpp 
> 171548b2017a0b97124f052c21345668e274d117 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3374d63b8311cf10b3108f56b7b167c12a9d7a37 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 9c64d7a4240f6d6df54ea00840908f2267c71d4f 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 33c47e73524d697589bcc6e0d42049508a468e62 
>   src/master/allocator/sorter/sorter.hpp 
> faebeb3ac3714ee971457dea7d643cce6c26df74 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/machine.hpp c0d4afc6715e217be8263cd5c274a9fda25769db 
>   src/master/maintenance.hpp 8d134aa44cac9003f6821bc418a22254869f2d6c 
>   src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71 
>   src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
>   src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a 
>   src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7 
>   src/sched/sched.cpp a1723f3cdd05289b417b4ea8bdd9b000655eccf8 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 6cfe9fa2971d50f545587b57721f75a981f6d5ed 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> dbdbf8722d088ef671b705c0c42191d0f9e05be9 
>   src/slave/containerizer/provisioners/appc/provisioner.cpp 
> 77f9cbe778785bd93c30eba5dfd7a470d9258661 
>   src/slave/containerizer/provisioners/backends/bind.cpp 
> 71861a9c971d12be4d77c8c39e99f2de4746f60f 
>   src/slave/containerizer/provisioners/docker/registry_client.hpp 
> b5e28587bc9adc2c02805b13fbc5c693612c99fb 
>   src/slave/containerizer/provisioners/docker/registry_client.cpp 
> b262ef031e0373ee009273e50a16d0a58ed83e8e 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/containerizer/docker_provisioner_tests.cpp 
> a3ccbc0fefa38f39e4fa06542c01af42c26df822 
>   src/tests/hierarchical_allocator_tests.cpp 
> 72e62737e9631f338d4637772d3e63516f7eac93 
>   src/tests/master_allocator_tests.cpp 
> 1fe3757f224281c312008e9010a95559cfff3dcf 
>   src/tests/master_maintenance_tests.cpp 
> 44785057f129a3e6a69f399f7d6db59d9d5c2e91 
>   src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 
>   src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION 
>   src/tests/reservation_endpoints_tests.cpp 
> 398a2e11cb334095f16b9e5529e6715e633d2c6f 
>   src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e 
>   src/tests/resource_offers_tests.cpp 
> af40a072bf5221cda42147e6f2c09d020a7f63f2 
>   src/tests/slave_recovery_tests.cpp dd8f823ffd970ed9a72f2dcbe161b3f62b3338df 
> 
> Diff: https://reviews.apache.org/r/38347/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to