> On 九月 15, 2015, 7:01 p.m., Vinod Kone wrote: > > include/mesos/scheduler.hpp, line 272 > > <https://reviews.apache.org/r/37532/diff/13/?file=1064326#file1064326line272> > > > > Should we even bother adding this to the old API? Note that adding a > > new call to the driver will impose a upgrade dependency between schedulers > > and master (master first, libmesos for scheduler next, scheduler jar last) > > > > more importantly, add a comment here that scheduler should call > > reviveOffers() to resume getting offers. > > Guangya Liu wrote: > I will consider adding this to old API in other patches.
Please ignore the comments above, I see that we are now having some discussion on this, I think that it is better to keep the old API before we drop it? Thanks. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review99061 ----------------------------------------------------------- On 九月 15, 2015, 11 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37532/ > ----------------------------------------------------------- > > (Updated 九月 15, 2015, 11 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3037 > https://issues.apache.org/jira/browse/MESOS-3037 > > > Repository: mesos > > > Description > ------- > > This is just part of MESOS-3037, this patch only add the interface > of QUIESCE call. > > > Diffs > ----- > > include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd > include/mesos/scheduler/scheduler.proto > 19f548dba4b5d72fca8e692c5f15796feca17106 > src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb > src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a > src/sched/sched.cpp a1723f3cdd05289b417b4ea8bdd9b000655eccf8 > > Diff: https://reviews.apache.org/r/37532/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >
