----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/#review99225 -----------------------------------------------------------
Ship it! Looks good! Similar to my comment on https://reviews.apache.org/r/38168/, please adjust the summary to something like "mesos: Replaced hard-coded reap interval with a constant." - Alexander Rukletsov On Sept. 9, 2015, 4:09 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38046/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2015, 4:09 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-1935 > https://issues.apache.org/jira/browse/MESOS-1935 > > > Repository: mesos > > > Description > ------- > > Replace hard-coded reap interval with a constant > > > Diffs > ----- > > src/tests/containerizer/launch_tests.cpp > d211fc0f665988068c67836ef80916828a0df2bd > src/tests/slave_recovery_tests.cpp 6aae14a3c39b9aee76147b691b0170946e1120b5 > src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 > > Diff: https://reviews.apache.org/r/38046/diff/ > > > Testing > ------- > > make distcheck > > > Thanks, > > Guangya Liu > >
