----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38011/#review99292 -----------------------------------------------------------
Patch looks great! Reviews applied: [38011] All tests passed. - Mesos ReviewBot On Sept. 16, 2015, 7:38 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38011/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2015, 7:38 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Artem > Harutyunyan, Joris Van Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > This removes the MachineIDs protobuf and changes it to instead use the > RepeatedFieldPtr. > This also changes the maintenance primitives (alpha) API for /machine/up and > /machine/down, which both take an array instead of an object now. > > > Diffs > ----- > > include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c > include/mesos/v1/mesos.proto bcce340777f037053e1eab2d75c351e53420b9da > src/common/protobuf_utils.hpp 86474eac116306e50f276bc0539de9bca66133e0 > src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46 > src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e > src/master/maintenance.hpp 8d134aa44cac9003f6821bc418a22254869f2d6c > src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71 > src/tests/master_maintenance_tests.cpp > 44785057f129a3e6a69f399f7d6db59d9d5c2e91 > src/tests/registrar_tests.cpp aa49c86c94446f17f705039075050296b4af1955 > > Diff: https://reviews.apache.org/r/38011/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Joseph Wu > >
