----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38011/#review97328 -----------------------------------------------------------
Patch looks great! Reviews applied: [37826, 37827, 37830, 38011] All tests passed. - Mesos ReviewBot On Sept. 1, 2015, 5:44 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38011/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2015, 5:44 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Artem > Harutyunyan, Joris Van Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > This removes the MachineIDs protobuf and changes it to instead use the > RepeatedFieldPtr. > This also changes the maintenance primitives (alpha) API for /machine/up and > /machine/down, which both take an array instead of an object now. > > > Diffs > ----- > > include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c > include/mesos/v1/mesos.proto fdd678b329bd15b412d9460d24d29387d2945630 > src/common/protobuf_utils.hpp 86474eac116306e50f276bc0539de9bca66133e0 > src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46 > src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e > src/master/maintenance.hpp bebaeb24efbd58df38796e3941f36a21791b6bfd > src/master/maintenance.cpp 277dd8270fbd497616e5b24db4ea7dd615e170e3 > src/tests/master_maintenance_tests.cpp > fb8dca3757a9565d5eb5a69eed10aa34602bb15c > src/tests/registrar_tests.cpp aa49c86c94446f17f705039075050296b4af1955 > > Diff: https://reviews.apache.org/r/38011/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Joseph Wu > >
