----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review99048 -----------------------------------------------------------
src/slave/containerizer/provisioners/docker/metadata_manager.hpp (line 64) <https://reviews.apache.org/r/38137/#comment155937> Create `an` Image. Not a big deal:) src/slave/containerizer/provisioners/docker/metadata_manager.cpp (line 221) <https://reviews.apache.org/r/38137/#comment156003> `getImageLayerRootfsPath` This method name is clear. src/slave/containerizer/provisioners/docker/paths.cpp (lines 36 - 39) <https://reviews.apache.org/r/38137/#comment155997> Is it necessary to attach the following comments? // Creates a temporary directory using the specified path // template. The template may be any path with _6_ `Xs' appended to // it, for example /tmp/temp.XXXXXX. The trailing `Xs' are replaced // with a unique alphanumeric combination. src/slave/containerizer/provisioners/docker/provisioner.cpp (lines 101 - 110) <https://reviews.apache.org/r/38137/#comment155877> {string _root} is suggested. src/slave/containerizer/provisioners/docker/provisioner.cpp (line 104) <https://reviews.apache.org/r/38137/#comment155884> This looks good to me. If the directory exists, no need to try. src/slave/containerizer/provisioners/docker/store.hpp (lines 53 - 59) <https://reviews.apache.org/r/38137/#comment155918> Comments of returned list scenario, with a given specified image. Of course, no need to do so if we decided to merge APPC and DOCKER provisioner together. - Gilbert Song On Sept. 11, 2015, 7:42 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38137/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 7:42 a.m.) > > > Review request for mesos, Jie Yu, Jojy Varghese, Till Toenshoff, and Jiang > Yan Xu. > > > Repository: mesos > > > Description > ------- > > Joining all the commits around provisioner and local store into one review so > it's easier to review, as patches > are changing code on top of each other. > > All the commits are going to committed together. > > > Diffs > ----- > > src/Makefile.am 8963cea > src/slave/containerizer/provisioner.hpp 9e0e0b8 > src/slave/containerizer/provisioner.cpp 2ac9008 > src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/message.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/message.proto PRE-CREATION > src/slave/containerizer/provisioners/docker/metadata_manager.hpp > PRE-CREATION > src/slave/containerizer/provisioners/docker/metadata_manager.cpp > PRE-CREATION > src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/provisioner.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/provisioner.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION > src/slave/flags.hpp 799c963 > src/slave/flags.cpp b676bac > src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38137/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
