> On Sept. 21, 2015, 11:22 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioner/docker/paths.hpp, line 40 > > <https://reviews.apache.org/r/38137/diff/9/?file=1078270#file1078270line40> > > > > What's this?
No longer needed with the shared provisioner change, thanks! > On Sept. 21, 2015, 11:22 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioner/docker/store.cpp, line 228 > > <https://reviews.apache.org/r/38137/diff/9/?file=1078275#file1078275line228> > > > > Why do you need the 'Nothing()' here? Just so we can chain callbacks. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review99772 ----------------------------------------------------------- On Sept. 21, 2015, 5:50 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38137/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2015, 5:50 p.m.) > > > Review request for mesos, Jie Yu, Jojy Varghese, Till Toenshoff, and Jiang > Yan Xu. > > > Repository: mesos > > > Description > ------- > > Joining all the commits around provisioner and local store into one review so > it's easier to review, as patches > are changing code on top of each other. > > All the commits are going to committed together. > > > Diffs > ----- > > src/Makefile.am 834f69a > src/slave/containerizer/provisioner.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/local_puller.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/local_puller.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/message.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/message.proto PRE-CREATION > src/slave/containerizer/provisioner/docker/metadata_manager.hpp > PRE-CREATION > src/slave/containerizer/provisioner/docker/metadata_manager.cpp > PRE-CREATION > src/slave/containerizer/provisioner/docker/paths.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/paths.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/puller.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/puller.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/store.cpp PRE-CREATION > src/slave/flags.hpp e31a418 > src/slave/flags.cpp add4196 > src/tests/containerizer/provisioner_docker_tests.cpp 1b0c304 > > Diff: https://reviews.apache.org/r/38137/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
