> On Sept. 17, 2015, 2:54 a.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner/docker/registry_client.cpp, line 499 > > <https://reviews.apache.org/r/38443/diff/1/?file=1075821#file1075821line499> > > > > If history array contains non JSON Object from the response I think it > > will just crash the slave. > > > > I realize in other places too, this becomes a bit tricky when docker > > registry changes their impl, or when user is targeting some other version > > of the registry I tihnk we shouldn't crash the whole slave.
if you mean the array sizes differences between history and fslayers then i have fixed the patch for that. - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38443/#review99351 ----------------------------------------------------------- On Sept. 17, 2015, 5:06 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38443/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2015, 5:06 p.m.) > > > Review request for mesos and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Added layerid information to ManifestResponse > > > Diffs > ----- > > src/slave/containerizer/provisioner/docker/registry_client.hpp > 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 > src/slave/containerizer/provisioner/docker/registry_client.cpp > 0a9663139b8a6d9e4fa458f7c893d33ca3a30e90 > src/tests/containerizer/provisioner_docker_tests.cpp > 1b0c30450a07d01d1a38d460bc7d921c80be7e3b > > Diff: https://reviews.apache.org/r/38443/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
