----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38443/#review100856 -----------------------------------------------------------
src/slave/containerizer/provisioner/docker/registry_client.cpp (line 79) <https://reviews.apache.org/r/38443/#comment158103> tokenMgr -> tokenManager, I can fix myself src/slave/containerizer/provisioner/docker/registry_client.cpp (line 505) <https://reviews.apache.org/r/38443/#comment158106> I think we need to say we failed because it's not the expected Object type. Same here and other placess you have the check Also you use index: in other places, and just index here. Let's be consistent and use index: - Timothy Chen On Sept. 25, 2015, 6:33 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38443/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 6:33 p.m.) > > > Review request for mesos and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Added layerid information to ManifestResponse > > > Diffs > ----- > > src/slave/containerizer/provisioner/docker/registry_client.hpp > 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 > src/slave/containerizer/provisioner/docker/registry_client.cpp > 0a9663139b8a6d9e4fa458f7c893d33ca3a30e90 > src/tests/containerizer/provisioner_docker_tests.cpp > d895eb9d0723e52cff8b21ef2deeaef1911d019c > > Diff: https://reviews.apache.org/r/38443/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
