----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/ -----------------------------------------------------------
(Updated Sept. 22, 2015, 12:22 a.m.) Review request for mesos, Benjamin Hindman, Cody Maloney, and Neil Conway. Changes ------- Removed dependency from LIBPROCESS_IP global invariant, after conversation with benh. Using instead the Master::info::ip Bugs: MESOS-3457 https://issues.apache.org/jira/browse/MESOS-3457 Repository: mesos Description ------- Under certain circumstances, dynamic lookup of hostname, while successful, provides undesirable results; we would also like, in those circumstances, be able to just set the hostname to the chosen IP address (possibly set via the --ip_discovery_command method). The flag we add here, --[no]-hostname_lookup is `true` by default (which is the existing behavior) and will work under most circumstances: however, by disabling lookup (using, for example, --no_hostname_lookup) the hostname used will be the same as the one configured (possibly, via --ip or MESOS_IP) in `LIBPROCESS_IP`. This change affects both Master/Agent nodes. WARNING - the `Address::hostname()` method always does a dynamic hostname lookup, which may in fact return inconsistent results wrt the Master's configuration (this is *not* affected by this change) and should be avoided; use instead `Master::info()::hostname()` which is always consistent with the Master's configuration. Diffs (updated) ----- docs/configuration.md dd7f4aa806a3c1a8653a0fda9a326a3707308e7c src/master/flags.hpp e4b1df3f5a33049defff4688463274067f1f1ebf src/master/flags.cpp 80879611fbcfd764c9fc8f60a31613a9c8fc2364 src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 src/slave/flags.hpp e31a4183170c3442ac4a15365c229391e7e91480 src/slave/flags.cpp add4196dfd06c0f602ff5ebd39960dc05c4cd11f src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287 src/tests/cluster.hpp 114583de8c867495a2b7a953e6826708838e5d23 src/tests/master_tests.cpp f26344d39543f65f2b0a94b8ff566836c8256bf7 Diff: https://reviews.apache.org/r/38473/diff/ Testing ------- make check Thanks, Marco Massenzio