-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38342/#review100413
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (line 609)
<https://reviews.apache.org/r/38342/#comment157588>

    s/protobuf(const T& message)/protobuf(const google::protobuf::Message& 
message)
    
    The templatization in 608 isn't necessary here, as the static_assert in 611 
has the same effect as just using a google::protobuf::Message as function 
parameter. Please change the function signature and remove line 608 & 611,612.
    
    Also, it'd make sense to return a `Try<Object>` as parsing `message` may 
fail. The current behavior is to call ABORT, one could as well return `None` 
here.



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (line 615)
<https://reviews.apache.org/r/38342/#comment157590>

    This comment describes a behavior of the function and should be moved to 
608 (= above the function signature).



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (line 772)
<https://reviews.apache.org/r/38342/#comment157593>

    Same as before: It'd make sense to return a `Try<Array>` here.


- Jan Schlicht


On Sept. 24, 2015, 5 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38342/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 5 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Jan Schlicht.
> 
> 
> Bugs: MESOS-3405
>     https://issues.apache.org/jira/browse/MESOS-3405
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which 
> converts a `google::protobuf::Message` into a `JSON::Object`.
> We should add the support for `google::protobuf::RepeatedPtrField<T>` by 
> introducing overloaded functions.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 2285ce9 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 68328a2 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 8ebb798 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 34eb6d0 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 920f5c9 
> 
> Diff: https://reviews.apache.org/r/38342/diff/
> 
> 
> Testing
> -------
> 
> cd 3rdparty/libprocess/3rdparty/stout
> ./boostrap
> ./configure
> make
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Reply via email to