> On Sept. 24, 2015, 9 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/provisioner/docker/local_puller.hpp, line 40 > > <https://reviews.apache.org/r/38137/diff/15/?file=1083921#file1083921line40> > > > > s/docker_discovery_local_dir/docker_local_archives_dir/ > > > > I suggested the flag name based on the suggestion about ArchivesPuller, > > I see that you are keeping the name LocalPuller (because we are not > > supporting remote archives right now) but changed the flag. > > > > Maybe s/LocalPuller/LocalArchivesPuller/ below for now to be > > consistent? > > > > We can revisit other archives locations after > > https://issues.apache.org/jira/browse/MESOS-3511.
Hmm ok I'll rename to LocalArchivesPuller - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review100449 ----------------------------------------------------------- On Sept. 24, 2015, 8:02 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38137/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 8:02 p.m.) > > > Review request for mesos, Jie Yu, Jojy Varghese, Till Toenshoff, and Jiang > Yan Xu. > > > Repository: mesos > > > Description > ------- > > Joining all the commits around provisioner and local store into one review so > it's easier to review, as patches > are changing code on top of each other. > > All the commits are going to committed together. > > > Diffs > ----- > > src/Makefile.am 776483b > src/slave/containerizer/provisioner/docker/local_puller.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/local_puller.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/message.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/message.proto PRE-CREATION > src/slave/containerizer/provisioner/docker/metadata_manager.hpp > PRE-CREATION > src/slave/containerizer/provisioner/docker/metadata_manager.cpp > PRE-CREATION > src/slave/containerizer/provisioner/docker/paths.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/paths.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/puller.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/puller.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/store.cpp PRE-CREATION > src/slave/containerizer/provisioner/store.cpp 35d1199 > src/slave/flags.hpp 3f6601a > src/slave/flags.cpp 8792162 > src/tests/containerizer/provisioner_docker_tests.cpp 1b0c304 > > Diff: https://reviews.apache.org/r/38137/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
