----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38726/#review100498 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Hindman On Sept. 24, 2015, 6:30 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38726/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 6:30 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-3510 > https://issues.apache.org/jira/browse/MESOS-3510 > > > Repository: mesos > > > Description > ------- > > This aids in verifying the files are kept in sync. > diff src/common/attributes.cpp src/v1/attributes.cpp should result > in only include and namespace differences. > > > Diffs > ----- > > src/common/attributes.cpp 8a8d6245135aff0a6cfde8dee46640770c38ed0d > > Diff: https://reviews.apache.org/r/38726/diff/ > > > Testing > ------- > > diff src/common/attributes.cpp src/v1/attributes.cpp > ``` > 24,25c24,25 > < #include <mesos/attributes.hpp> > < #include <mesos/values.hpp> > --- > > #include <mesos/v1/attributes.hpp> > > #include <mesos/v1/values.hpp> > 34d33 > < > 35a35 > > namespace v1 { > 227a228 > > } // namespace v1 { > ``` > > > Thanks, > > Joris Van Remoortere > >
