-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38754/#review100614
-----------------------------------------------------------

Ship it!



3rdparty/CMakeLists.txt (lines 25 - 26)
<https://reviews.apache.org/r/38754/#comment157835>

    Do you have plans to combine this with the similar lines in 
`3rdparty/libprocess/3rdparty/CMakeLists.txt`?
    (Especially the `UPSTREAM_URL`).



3rdparty/cmake/Mesos3rdpartyConfigure.cmake (lines 32 - 36)
<https://reviews.apache.org/r/38754/#comment157831>

    Nit: Spacing seems off in two of these lines.


- Joseph Wu


On Sept. 24, 2015, 11:19 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38754/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 11:19 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3381
>     https://issues.apache.org/jira/browse/MESOS-3381
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Add build/configure/install logic for Zookeeper.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt PRE-CREATION 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake PRE-CREATION 
>   3rdparty/cmake/Versions.cmake PRE-CREATION 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/38754/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to