> On Sept. 25, 2015, 5:12 p.m., Joseph Wu wrote:
> > 3rdparty/CMakeLists.txt, lines 25-26
> > <https://reviews.apache.org/r/38754/diff/1/?file=1084607#file1084607line25>
> >
> >     Do you have plans to combine this with the similar lines in 
> > `3rdparty/libprocess/3rdparty/CMakeLists.txt`?
> >     (Especially the `UPSTREAM_URL`).

I don't currently. Initial thinking was that we should redefine them for 
libprocess and Stout individually to avoid coupling them to Mesos. I'm open to 
changing this though, since it means we have to keep two definitions.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38754/#review100614
-----------------------------------------------------------


On Sept. 25, 2015, 6:19 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38754/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 6:19 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3381
>     https://issues.apache.org/jira/browse/MESOS-3381
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Add build/configure/install logic for Zookeeper.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt PRE-CREATION 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake PRE-CREATION 
>   3rdparty/cmake/Versions.cmake PRE-CREATION 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/38754/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to