-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38577/#review100653
-----------------------------------------------------------



src/Makefile.am (line 501)
<https://reviews.apache.org/r/38577/#comment157880>

    I think you'll make Alex happy if you also update the corresponding CMake 
file(s).



src/slave/validation.hpp (line 36)
<https://reviews.apache.org/r/38577/#comment157884>

    Can you please add tests in this patch?



src/slave/validation.cpp (lines 35 - 43)
<https://reviews.apache.org/r/38577/#comment157882>

    I would swap the order of these.


- Vinod Kone


On Sept. 22, 2015, 9:46 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38577/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 9:46 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-2906
>     https://issues.apache.org/jira/browse/MESOS-2906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added validation for Call protobuf message in Agent /api/v1/executor endpoint.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e224060 
>   src/slave/http.cpp 12a4d39 
>   src/slave/validation.hpp PRE-CREATION 
>   src/slave/validation.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38577/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Reply via email to