----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100641 -----------------------------------------------------------
src/CMakeLists.txt (line 1) <https://reviews.apache.org/r/38756/#comment157860> I think this file belongs in src/slave. And from top level src/ dir we should just be pulling CMakeLists.txt files from component directories. What do you think? src/CMakeLists.txt (lines 123 - 125) <https://reviews.apache.org/r/38756/#comment157859> Extra newlines. src/slave/cmake/AgentConfigure.cmake (line 1) <https://reviews.apache.org/r/38756/#comment157951> Can we keep calling this slave for the time being? It will take a while until we get to file and directory rename (it's pretty low in Ben's list). - Artem Harutyunyan On Sept. 24, 2015, 11:20 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38756/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 11:20 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3385 > https://issues.apache.org/jira/browse/MESOS-3385 > > > Repository: mesos > > > Description > ------- > > CMake: Add support for compiling the agent with CMake. > > > Diffs > ----- > > CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 > cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 > src/CMakeLists.txt PRE-CREATION > src/cmake/MesosProtobuf.cmake PRE-CREATION > src/slave/cmake/AgentConfigure.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/38756/diff/ > > > Testing > ------- > > Compiled and ran made sure libprocess and stout tests ran and passed on the > following platforms: > > * OS X 10.10 > * Ubuntu 14.04.2 > > > Thanks, > > Alex Clemmer > >
